Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jsdoc type for config blocks #3

Merged
merged 1 commit into from
Sep 22, 2024
Merged

feat: add jsdoc type for config blocks #3

merged 1 commit into from
Sep 22, 2024
+4 −0

Conversation

andrewbrey
Copy link
Contributor

@andrewbrey andrewbrey commented Sep 22, 2024 •
edited
Loading

🔗 Linked issue

Fixes #2

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add JSDoc type information for the configBlocksToMerge parameter of both configPkg and configApp. Doing this greatly improves the autocomplete experience for users who wish to override any part of the base config.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit 42aeb82 into adonisjs:v2 Sep 22, 2024
@thetutlage
Copy link
Member

Thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing type information for config blocks
2 participants
@andrewbrey @thetutlage