Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gradle.properties file to the cache key #460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hurricup
Copy link

@hurricup hurricup commented Mar 4, 2023

Part of project configuration may be in the gradle.properties file and changing it should invalidate cache

See: https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@hurricup hurricup requested a review from a team as a code owner March 4, 2023 04:49
@dmitry-shibanov
Copy link
Contributor

Hello @hurricup. Thank you for your pull request. We'll take a look on it. Could you please attach an issue if it exists? Besides, could you please regenerate dist with npm run build command.

@hurricup
Copy link
Author

hurricup commented Mar 5, 2023

There is no issue, just stumbled on it while migrating to re-usable workflows.

Part of project configuration may be in the `gradle.properties` file and changing it should invalidate cache

See: https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_configuration_properties
@hurricup hurricup force-pushed the hurricup/properties-cahce-dependency branch from 8547b4a to a76faeb Compare March 5, 2023 12:54
@IvanZosimov IvanZosimov added feature request New feature or request to improve the current logic needs eyes labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants