Make new dashboard page the root of the Yoast SEO menu

[leonidasmi]

Context

Summary

This PR can be summarized in the following changelog entry:

• Moves the new dashboard page to the root of the Yoast SEO menu

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Add the define( 'YOAST_SEO_NEW_DASHBOARD_UI', true ); define
• Go to the Yoast SEO menu item or to the Yoast SEO->General menu item
• Confirm that you see the new dashboard design
• Remove the define and refresh
• Confirm that you see the old page

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• Regression test the Yoast menu item in all scenarios, both with the define enabled and disabled (the only difference should be that with the define enabled, you see the new dashboard when expected)
  • In multisite
  • When not an admin but with other user roles
  • With all add-ons enabled.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• [] I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 29c8576b08d4e0ea6ac8e8499f462c14ac2990df

Details

• 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+5.2%) to 54.732%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
admin/menu/class-admin-menu.php	0	2	0.0%

Totals
Change from base Build c57ccb95b2e11321967993885e7d0768ddeb3b0c:	5.2%
Covered Lines:	29768
Relevant Lines:	54636

---

💛 - Coveralls

[thijsoo]

CR + ACC 👍