Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement useAnchor #21615

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Sep 10, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the link popover would be hidden when editing post in tablet/mobile view. Props to stokesman.

Relevant technical choices:

  • Disabled prop types lint error since Link is not a react component.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

For context: This is a video showing the bug.

  • Edit a post
  • Select text and try to add it a link, see that you get a popover with an input to add a link.
  • Switch to the tablet or mobile view and try to see that you still get the same popover.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Quickly smoke test our integration with the block editor, looking for console errors.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Update edit link popover anchoring to work with the iframed Post editor

@vraja-pro vraja-pro added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Sep 10, 2024
Copy link
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance Test is ✔️

@leonidasmi leonidasmi added this to the 23.6 milestone Sep 11, 2024
@leonidasmi leonidasmi merged commit 0e731b5 into trunk Sep 11, 2024
16 checks passed
@leonidasmi leonidasmi deleted the 21602-update-link-format-implementation-to-work-with-the-iframed-post-editor branch September 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update edit link popover anchoring to work with the iframed Post editor
2 participants