Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

[1737] Renaming files to remove deprecation warnings #1738

Closed
wants to merge 2 commits into from
Closed

[1737] Renaming files to remove deprecation warnings #1738

wants to merge 2 commits into from

Conversation

ccadden
Copy link

@ccadden ccadden commented Jul 18, 2018 •
edited by orenyk
Loading

Closes #1737

@orenyk orenyk changed the title Renaming files to remove deprication warnings [1738] Renaming files to remove deprecation warnings Jul 19, 2018
@orenyk
Copy link
Contributor

orenyk commented Jul 19, 2018

@Mr-sigma we might need to update rubocop or something to fix the build; I'm cool to ignore the Codeclimate issues. Can you see if bundle update rubocop helps? Add it as a separate commit to the branch. Thanks!

@orenyk orenyk changed the title [1738] Renaming files to remove deprecation warnings [1737] Renaming files to remove deprecation warnings Jul 19, 2018
@orenyk
Copy link
Contributor

orenyk commented Jul 19, 2018

Also, please update your commit message to include Resolves #1737 after the main message. Thanks!

@ccadden
Copy link
Author

ccadden commented Jul 19, 2018

@orenyk updated rubocop to 0.58.1, but still getting the same error on bundle exec rake check_style.

@ccadden ccadden closed this Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename *.css.scss to *.scss
2 participants
@ccadden @orenyk