Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added experimental background job queue #20985
base: main
Are you sure you want to change the base?
Added experimental background job queue #20985
Changes from all commits
fa3773a
0944f8e
cbfb1a2
d74d339
e3b68ec
f47448b
713dcc4
4b3b928
85c28ea
010369b
62807b9
e253203
125f3d7
7aeb7e0
5508cfd
c602c67
2cd905f
e5529c0
aa8fc8b
6694210
2fd8caf
22b76b0
1d77f5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker but just a note for future: it would be good to get to the bottom of why we need two instances of the job system, and ideally fix that so we don't need this anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I've got a note to look into this because this is rather clunky way of handling it that I'm also really not a fan of.
Check warning on line 58 in ghost/core/test/integration/jobs/job-queue.test.js
GitHub Actions / Database tests (Node 18.12.1, sqlite3)