Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed flaky 'can update a published post' browser test #20935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed flaky 'can update a published post' browser test #20935

wants to merge 1 commit into from
+5 −2

Conversation

cmraible
Copy link
Contributor

@cmraible cmraible commented Sep 6, 2024 •
edited
Loading

no issue

  • These two tests were relying on the ordering of the posts in the posts list, which can vary when running the test suite all together (as we do in CI), since multiple tests can be running and creating/deleting posts in parallel.
  • This commit navigates directly to the post's URL to avoid this problem.

@cmraible cmraible force-pushed the fix-flaky-publishing-tests branch 2 times, most recently from 4f4191f to 9befa60 Compare September 6, 2024 16:45
@cmraible cmraible marked this pull request as ready for review September 6, 2024 17:10
@cmraible cmraible changed the title Fixed flaky publishing tests Fixed flaky 'can update a published post' browser test Sep 6, 2024
@cmraible cmraible closed this Sep 6, 2024
@cmraible cmraible reopened this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
browser-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmraible