Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual GitHub setup guide #320

Merged
merged 13 commits into from
Jun 19, 2023
Merged

Manual GitHub setup guide #320

merged 13 commits into from
Jun 19, 2023

Conversation

simonswiss
Copy link
Collaborator

I know I myself requested we depart from screenshot-heavy guides, but...

... it's pretty hard to do a guide about going through specific screens and UIs without providing screenshots 😅

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

⚠️ No Changeset found

Latest commit: f111dbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keystatic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:57am
keystatic-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:57am
voussoir ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:57am

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit: could we call this like "local GitHub app setup" or something and the other one like "Vercel GitHub app setup"? manual vs automatic is quite inaccurate since they're both quite "automatic". from my perspective, "manual" setup means clicking around in GitHub's UI to create the GitHub app which is not what this is

@simonswiss
Copy link
Collaborator Author

This guide is meant to eventually also show how to setup the remote (not necessarily Vercel) by copying the environment variables over to the host.

But I do agree, this doesn't really feel any more "manual" — you still go through the automated GitHub app creation, just not via a starter template. I think your naming suggestion makes sense — I could make those changes part of this PR.

What are your thoughts @BarnabyBishop?

Copy link
Contributor

@BarnabyBishop BarnabyBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

docs/src/content/navigation.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants