-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual GitHub setup guide #320
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming nit: could we call this like "local GitHub app setup" or something and the other one like "Vercel GitHub app setup"? manual vs automatic is quite inaccurate since they're both quite "automatic". from my perspective, "manual" setup means clicking around in GitHub's UI to create the GitHub app which is not what this is
This guide is meant to eventually also show how to setup the remote (not necessarily Vercel) by copying the environment variables over to the host. But I do agree, this doesn't really feel any more "manual" — you still go through the automated GitHub app creation, just not via a starter template. I think your naming suggestion makes sense — I could make those changes part of this PR. What are your thoughts @BarnabyBishop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
I know I myself requested we depart from screenshot-heavy guides, but...
... it's pretty hard to do a guide about going through specific screens and UIs without providing screenshots 😅