fix lint errors

Thinkmill · Sep 2, 2024 · ef8fa26 · ef8fa26
1 parent 6eb8bcc
commit ef8fa26
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/design-system/pkg/src/list-view/ListView.tsx b/design-system/pkg/src/list-view/ListView.tsx
@@ -66,9 +66,9 @@ function useListLayout<T>(
   let layout = useMemo(
     () =>
       new ListViewLayout<T>({
-        estimatedRowHeight: ROW_HEIGHTS[density][scale],
+        estimatedRowHeight:
+          overflowMode === 'wrap' ? undefined : ROW_HEIGHTS[density][scale],
       }),
-    // eslint-disable-next-line react-hooks/exhaustive-deps
     [scale, density, overflowMode]
   );
 

diff --git a/design-system/pkg/src/table/InsertionIndicator.tsx b/design-system/pkg/src/table/InsertionIndicator.tsx
@@ -25,6 +25,8 @@ export function InsertionIndicator(props: InsertionIndicatorProps) {
   );
   assert(!!dropState, 'dropState is not defined.');
 
+  // if the indicator is rendered dnd hooks are defined
+  // eslint-disable-next-line react-compiler/react-compiler
   let { dropIndicatorProps } = dragAndDropHooks.useDropIndicator(
     props,
     dropState,

diff --git a/design-system/pkg/src/table/TableView.tsx b/design-system/pkg/src/table/TableView.tsx
@@ -207,8 +207,6 @@ export function TableView<T extends object>(
         estimatedHeadingHeight:
           props.overflowMode === 'wrap' ? DEFAULT_HEADER_HEIGHT : undefined,
       }),
-    // don't recompute when state.collection changes, only used for initial value
-    // eslint-disable-next-line react-hooks/exhaustive-deps
     [props.overflowMode, density]
   );
 

diff --git a/design-system/pkg/src/tooltip/test/TooltipTrigger.test.tsx b/design-system/pkg/src/tooltip/test/TooltipTrigger.test.tsx
@@ -386,6 +386,7 @@ describe('tooltip/TooltipTrigger', () => {
     });
 
     // can't get this to work with timers
+    // eslint-disable-next-line jest/no-commented-out-tests
     // it('opens for hover', async () => {
     //   let { getByRole, getByLabelText } = renderWithProvider(
     //     <TooltipTrigger onOpenChange={onOpenChange}>