-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api #403
base: master
Are you sure you want to change the base?
Api #403
Conversation
✨ create Category entity with relation to DSL and Data point ✨ create DSL entitry with relation to category
✨ create DataPoint Module ✨ create Category Module
✨add controller for DSL, Categoty
🚨 fix sonar lint issue
✏️ fix type error 🚚 rename files
🚚 rename datasetEntry to DataSetEntries
⚰️ Remove Swagger Documentation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
host: process.env.DB_HOST, | ||
port: process.env.DB_PORT as any, | ||
username: process.env.DB_USERNAME, | ||
password: process.env.DB_PASSWORD, | ||
database: process.env.DB_DATABASE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a pre-screen checking if those variables are available in env? I just dont know what happens if one of those variables is null?
host: process.env.DB_HOST, | ||
database: process.env.DB_DATABASE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question with one below that what happens if one of those is null?
And I was wondering that we should put all retrieving env variables in 1 module/file or we use it directly in different files?
I think it is easier for us to change if we put them all in one file. Like we want to change variable name in .env file? Also, we may repeat running process.env many times when we scatter them in many files.
On other hand, use them directly is easier and faster to develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this is a big problem since we can refactor our code quickly later. But I just want to know which one should we chose.
Manage this branch in SquashTest this branch here: https://api-av8tm.squash.io |
No description provided.