-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete tags in the preview panel #495
base: main
Are you sure you want to change the base?
Conversation
I'll read through the code, but same thing as with #481 - please add some tests to verify the behaviour automatically and to prevent regressions in future. There are some existing tests for widgets in |
Yep that's fine, I made this before I looked at that pr so can add some tests to both of them. |
@CyanVoxel can you please enable the workflow to run on this PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
here's a bug: Steps to reproduce:
Expected behaviour:
Current behaviour:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests for the widget, thanks.
Added tests and fixed the bugs 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good, beside the Enter behaviour on no-match. good job.
Changes made |
please fix the pipeline |
it's quite misbehaving Screen.Recording.2024-09-22.at.8.21.15.mov |
What. I've never seen it do that. |
Adds autocomplete to tags in the preview panel, for all tag fields.
You can now add tags through several methods:
a. Clicking enter to get the first tag that matches the text
b. Using the arrow keys to select a tag from the autocomplete popup
c. Clicking on a tag from the autocomplete popup
Requires #481