Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved home screen, changed onboarding text, NCI Trial API recursion #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexaaalami
Copy link
Collaborator

Improved home screen, changed onboarding text, NCI Trial API recursion

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 18.33%. Comparing base (7a2c9a6) to head (a89556f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   18.37%   18.33%   -0.04%     
==========================================
  Files          59       59              
  Lines        1998     2003       +5     
==========================================
  Hits          367      367              
- Misses       1631     1636       +5     
Files Coverage Δ
OwnYourData/Instructions/InstructionsView.swift 100.00% <100.00%> (+13.80%) ⬆️
OwnYourData/Onboarding/Welcome.swift 94.60% <100.00%> (ø)
OwnYourData/Home.swift 78.69% <50.00%> (-1.31%) ⬇️
OwnYourData/ClinicalTrials/NCITrialsModule.swift 7.50% <0.00%> (-0.95%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2c9a6...a89556f. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you @alexaaalami 🚀

@PSchmiedmayer PSchmiedmayer added bug Something isn't working enhancement New feature or request labels Jun 13, 2024
Minor text edits made to the "Welcome" page, as well as removal of the "Learn more..." link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants