Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOOM-1668 backpack date picker fires change event on value change #3608

Merged
merged 8 commits into from
Sep 18, 2024
Merged

LOOM-1668 backpack date picker fires change event on value change #3608

merged 8 commits into from
Sep 18, 2024

Conversation

amburrrshand
Copy link
Contributor

@amburrrshand amburrrshand commented Sep 16, 2024 •
edited
Loading

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@amburrrshand amburrrshand added the minor Non breaking change label Sep 16, 2024
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 9ada1b3

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

1 similar comment
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@olliecurtis olliecurtis mentioned this pull request Sep 16, 2024
Merged
@olliecurtis olliecurtis force-pushed the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch from a6eddf9 to 4f64849 Compare September 16, 2024 16:12
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@olliecurtis olliecurtis force-pushed the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch from 4f64849 to 3fbe1f7 Compare September 16, 2024 16:32
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

2 similar comments
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@amburrrshand amburrrshand force-pushed the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch from 17693f1 to 78f55e5 Compare September 17, 2024 13:00
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

olliecurtis
olliecurtis reviewed Sep 17, 2024
View reviewed changes
packages/bpk-component-datepicker/src/BpkDatepicker.tsx Outdated
inputRef: React.RefObject<HTMLInputElement>;
inputRef: (ref:HTMLInputElement) => void;

myRef?: HTMLInputElement;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth changing this to be something like elementRef just to keep confusion and wonder down so it doesn't look like a debugging variable :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout! I've changed that now

@amburrrshand amburrrshand force-pushed the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch from a75c359 to 0a19d99 Compare September 17, 2024 13:54
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@amburrrshand amburrrshand force-pushed the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch from 0e36897 to 994ca95 Compare September 17, 2024 14:23
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3608 to see this build running in a browser.

metalix2
metalix2 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@metalix2 metalix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this 👍

@amburrrshand amburrrshand merged commit 5c41040 into main Sep 18, 2024
9 checks passed
@amburrrshand amburrrshand deleted the LOOM-1668-backpack-date-picker-fires-change-event-on-value-change branch September 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalix2 metalix2 metalix2 approved these changes

@olliecurtis olliecurtis olliecurtis approved these changes

Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amburrrshand @metalix2 @olliecurtis @ambershand