Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOOM-1520][BpkSlider] Fix for Slider to support Form properly #3567

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

metalix2
Copy link
Contributor

@metalix2 metalix2 commented Aug 2, 2024

The Slider currently provides a default invisible input when wrapped in a form. We don't want to use this as we can't control any aspects of this input. onChange events, custom attributes like (type, form) . I've raised a ticket to add support for an inputRef Prop to radix-ui but until then we can rely on using our own composition and defining the BubbleInput ourselves.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@metalix2 metalix2 added minor Non breaking change enhancement javascript Pull requests that update Javascript code labels Aug 2, 2024
@metalix2 metalix2 changed the title [LOOM]Fix for Slider to support Form properly [LOOM-1520][BpkSlider] Fix for Slider to support Form properly Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Visit https://backpack.github.io/storybook-prs/3567 to see this build running in a browser.

Copy link

github-actions bot commented Aug 2, 2024

Visit https://backpack.github.io/storybook-prs/3567 to see this build running in a browser.

Copy link

github-actions bot commented Aug 2, 2024

Visit https://backpack.github.io/storybook-prs/3567 to see this build running in a browser.

Copy link

github-actions bot commented Aug 2, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 382877f

@metalix2 metalix2 merged commit 7d9573d into main Aug 6, 2024
9 checks passed
@metalix2 metalix2 deleted the SliderFix branch August 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement javascript Pull requests that update Javascript code minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants