Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[res] CircleRecipes and TFLiteRecipes added for RmsNorm #14022

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[res] CircleRecipes and TFLiteRecipes added for RmsNorm #14022

wants to merge 3 commits into from

Conversation

seockho-kim
Copy link
Contributor

@seockho-kim seockho-kim commented Sep 13, 2024 •
edited
Loading

This commit adds RmsNorm test recipe in CircleRecipes/TFLiteRecipes.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]

issue: #13964
draft: #13967

@seockho-kim
[res] CircleRecipes and TFLiteRecipes added for RmsNorm
57b23c6 
This commit adds RmsNorm test recipe in CircleRecipes/TFLiteRecipes.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
@seockho-kim
[res] Fixed RmsNorm TFLiteRecipes
3cfdf89 
This commit fixes RmsNorm TFLiteRecipes.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
@seanshpark
Copy link
Contributor

[ 76%] Generate RmsNorm_000.opt.circle
terminate called after throwing an instance of 'oops::UserExn'

check with adding to exclude.lst like

## CircleRecipes

optimize(RmsNorm_000)

@seockho-kim
Copy link
Contributor Author

[ 76%] Generate RmsNorm_000.opt.circle
terminate called after throwing an instance of 'oops::UserExn'

check with adding to exclude.lst like

## CircleRecipes

optimize(RmsNorm_000)

Thanks :)
I've tried to fix it, but I couldn't
I'll update it

@seockho-kim
[common-artifacts] RmsNorm optimization excluded.
bb92d84 
This commit is to exclude RmsNorm optimization test until it's fully applied.
It will be reverted once RmsNorm is fully applied.

ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
seanshpark
seanshpark reviewed Sep 18, 2024
View reviewed changes
compiler/common-artifacts/exclude.lst
@@ -9,6 +9,7 @@ optimize(Add_STR_000) # STRING is not supported
optimize(Add_STR_001) # STRING is not supported

## CircleRecipes
optimize(RmsNorm_000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz split this to another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz split this to another PR.

Okay, I'll submit another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark seanshpark left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
[ONE] onert - LLM support
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seockho-kim @seanshpark