Actually allow maps and lua files to be placed within the campaign folder #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the LUA code easier to read
Flamefire
force-pushed
the
relative-campaign-folders
branch
2 times, most recently
from
f1aed08
to
0e9a986
Compare
Now the image is either a non-empty string or `nullopt`
…lder. Although this is documented it was not implemented. Make both folders optional defaulting to the campaign folder.
Flamefire
force-pushed
the
relative-campaign-folders
branch
from
0e9a986
to
2a10176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is documented it was not implemented.
Make both folders optional defaulting to the campaign folder.
I also restricted this to a single subfolder. If it contains anything else, i.e. a parent folder, it must be a (restricted) path as in the other path references in lua files, i.e. start with
<RTTR_...>and do not contain upward references.I also replaced the script-strings in the test by C++11 raw strings to avoid the many backslashes and quotes that make them rather hard to read.