Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix removeRow #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix removeRow #135

wants to merge 2 commits into from

Conversation

xiaweiss
Copy link

@xiaweiss xiaweiss commented Mar 10, 2021

commit 1: fix removeRow mistake: (row < map.width) -> (row < map.height)

Before delete row

image

After delete row

image

this condition is checked merged cell in next line, so it should be row < map.height
when we fixed it:
image

commit 2: fix removeRow when skips columns when adjusting rowspan

when skip col,we get next col,but index not update, map.map[index] and map.positionAt(row, col, table) is not the same cell
see issue #136

@xiaweiss xiaweiss changed the title fix removeRow mistake: (row < map.width) -> (row < map.height) fix removeRow Mar 10, 2021
@xiaweiss
Copy link
Author

xiaweiss commented Apr 6, 2021

@marijnh

@marijnh
Copy link
Member

marijnh commented Apr 6, 2021

This repository is not currently being maintained. If you want to set up (and maintain) a fork, or ask the current owners if they'll let you take over, that might work. But I don't currently have time to review PRs on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants