rc: use /etc/hostname if available #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
approved these changes
Jan 25, 2023
This is significantly less overhead than an init script.
dwfreed
requested changes
Jul 26, 2024
|
|
||
| if (rc_getfile(RC_SYSCONFDIR "/hostname", &buffer, &len)) { | ||
| if (buffer[len - 2] == '\n') | ||
| buffer[--len - 1] = '\0'; |
There was a problem hiding this comment.
Please split this into 2 lines; it'd be much more readable that way.
| size_t len; | ||
|
|
||
| if (rc_getfile(RC_SYSCONFDIR "/hostname", &buffer, &len)) { | ||
| if (buffer[len - 2] == '\n') |
There was a problem hiding this comment.
This doesn't handle the case where len is 0 or 1, resulting in an out of bounds read and potentially an out of bounds write (!!!)
| char *buffer = NULL; | ||
| size_t len; | ||
|
|
||
| if (rc_getfile(RC_SYSCONFDIR "/hostname", &buffer, &len)) { |
There was a problem hiding this comment.
The hostname tool from net-tools on Linux has a -b flag that will fall back to setting the hostname to localhost if the file does not exist or is empty; this would probably be a good idea to implement, as on Linux, the hostname could be an empty string otherwise. hostname also allows for comment lines (line starts with #) in /etc/hostname, which are ignored; this could also be useful.
williamh
added a commit
that referenced
this pull request
Jul 26, 2024
This is an alternative to #585 in which we keep the init script but use `hostname -F` to read the value from @SYSCONFDIR@/hostname. This allows for comments in the hostname file. Also, we deprecate using /etc/conf.d/* to set the host name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is significantly less overhead than an init script.