bootmisc: use find ... -delete for all cleanup in tmp directories #467
Conversation
|
@kaniini @vapier @richfelker Any comments on this? |
|
I think doing it that way is going to be safer, but I also think that we should still have an option to turn off the wiping entirely, like Debian's |
|
@kaniini Does setting |
|
Setting |
|
if you set as i noted in the bug, using find unconditionally negatively impacts just about everyone just to hypothetically make a corrupted system less corrupt. this change is the wrong direction to go. |
williamh
force-pushed
the
bootmisc-find
branch
from
3002664
to
f4e8b69
Compare
williamh
force-pushed
the
bootmisc-find
branch
from
f4e8b69
to
90f7479
Compare
|
@robbat2 I'll give a few more hours before i merge this, but I was chatting with @kaniini tonight and we were talking about using the commands from Debian again. That's what the secomd commit on this pr does, and it seems that it would also allow removing the last find. Please comment on whether it is reasonable to squash and merge these or whether I should just merge the first commit into master. |
|
I think this is fine 👍 Would be nice if this should be merged. Thanks! |
|
except none of the problems highlighted have been addressed |
init.d/bootmisc.in
Outdated
| # Blah, too many files | ||
| find . -maxdepth 1 -name '[!ajlq\.]*' -exec rm -rf -- {} + | ||
| fi | ||
| find "${dir}" -xdev -maxdepth 1 -name '[!ajlq\.]*' -exec rm -rf -- {} + |
There was a problem hiding this comment.
this doesn't actually ignore submounts because rm -rf is still being invoked on the topdir. e.g. /tmp/foo/bar mountpoints.
This is for #458