feat: modified meshT file to receive material info instead of texture #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces significant changes to the MeshT file in the obj2tiles open-source project, enabling it to handle materials instead of textures. While this modification allows for material assignment, it currently results in a loss of color and shading in the converted models.
To further enhance the visual quality of the converted models and introduce shading and edge effects, I would like to seek guidance and suggestions from the main contributors. Specifically, I am interested in implementing a Phong shading model for the materials.
The Phong shading model simulates the interaction of light with surfaces, taking into account ambient, diffuse, and specular lighting contributions. By incorporating this model, we can achieve more realistic shading and enhance the overall visual appeal of the converted models.
I would greatly appreciate any insights, recommendations, or code guidance from the experienced contributors on how to modify the material handling code to incorporate the Phong shading model effectively. Together, we can collaborate to enhance the capabilities of obj2tiles and deliver visually stunning results.
Thank you in advance for your support and expertise in this matter. I look forward to your valuable feedback and suggestions for implementing Phong shading and achieving the desired shading and edge effects in the converted models.
@HeDo88TH