Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to angular cli 14.1.3 node 14.21.3 npm 6.14.18 / fix access to… #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ThomasBTR
Copy link

@ThomasBTR ThomasBTR commented Mar 17, 2023

… rental creation page

works too with latest Gallium lts (v16.19.1)

… rental creation page

works to with latest Gallium lts (v16.19.1)
@ThomasBTR
Copy link
Author

image

@ThomasBTR
Copy link
Author

@JoffreyHernandez can you take that in account after review ?
Thanks in advance.

Copy link

@clementolive clementolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. The first change was allowing creating but not updating. My local change is like this (it should work either way). The ID check must happen only if rental exists, otherwise we get redirected instantly. Thanks for the request

      if(rental?.owner_id !== this.sessionService.user!.id) {
        if (rental !== undefined) this.router.navigate(['/rentals']);
      }

@ThomasBTR
Copy link
Author

Thanks for your reply, @achmoye !
It works both ways yes. I had an issue because i was not using snake_case but CamelCase from backend. The upgrade of angular CLI is nice thought, with the security measures expected as of required on the project.
I can do another pull request for this project only regarding angular upgrade if you want and close this one or only cherry pick the upgrade is this upgrade is not needed.
Up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants