Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Optional Cargo Stylus Version Flag for Verification #93

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

rauljordan
Copy link
Contributor

Description

Allows a deployer and verifier doing reproducible actions in Docker to specify the cargo stylus version flag to be used in their Docker image. When Cargo stylus runs deployments or verification through Docker, it downloads an image called cargo-stylus-base:$VERSION. It currently defaults to the local binary's version for cargo stylus, but verifiers such as Etherscan benefit from being able to specify the user's cargo stylus version during verification

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit c6c92d6 into main Sep 3, 2024
7 checks passed
@rauljordan rauljordan deleted the v0.5.2 branch September 3, 2024 16:46
@rauljordan rauljordan restored the v0.5.2 branch September 3, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants