Fixed the gas estimation tutorial not working on arbitrum goerli #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to that chain not settling on an L1
TucksonDev
reviewed
Dec 12, 2023
| // If the L1 price is 0, we set the size to 0 | ||
| l1Size = 0; | ||
| }else{ | ||
| l1Size = l1Cost.div(l1EstimatedPrice).add(140); |
There was a problem hiding this comment.
I think the 140 bytes are already factored in at this point and you don't need to add them. L1 cost has the full cost of the L1 component, including the 140 extra bytes.
TucksonDev
reviewed
Dec 12, 2023
| let l1Size; | ||
| if(l1EstimatedPrice.eq(0)) { | ||
| // If the L1 price is 0, we set the size to 0 | ||
| l1Size = 0; |
There was a problem hiding this comment.
Can you cast this as a BigNumber to keep consistency between both sides of the condition?
TucksonDev
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks very much @BarneyChambers , this is a great catch!
I added two minor comments.
What I think is happening here is that even though Arbitrum Goerli settles to Ethereum Goerli (L1), sometimes the L1 estimated price is so small that it is rounded to 0. During Dec 8th and Dec 9th, for example, there was a gas dip where the base fee was just a few wei (not gwei).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a gas estimation issue on the Arbitrum Goerli testnet. The core problem stemmed from the fact that Arbitrum Goerli does not settle its transactions on Layer 1 (L1), leading to a division by zero error in gas estimation.
Changes