fix: correct gas estimations for eth custom destination #1956
+105
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
changed the title
brtkx
changed the title
dewanshparashar
previously approved these changes
Oct 2, 2024
fionnachan
reviewed
Oct 4, 2024
packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx
Outdated
Show resolved
Hide resolved
dewanshparashar
previously approved these changes
Oct 10, 2024
…token-bridge into eth-custom-dest-4
fionnachan
reviewed
Oct 14, 2024
packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx
Outdated
Show resolved
Hide resolved
| @@ -32,6 +33,40 @@ export class EthDepositStarter extends BridgeTransferStarter { | |||
| return this.ethBridger | |||
| } | |||
|
|
|||
| private async getParentRetryableGas({ | |||
…e into eth-custom-dest-4
fionnachan
previously approved these changes
Oct 22, 2024
dewanshparashar
previously approved these changes
Oct 22, 2024
spsjvc
reviewed
Oct 31, 2024
| @@ -32,6 +33,40 @@ export class EthDepositStarter extends BridgeTransferStarter { | |||
| return this.ethBridger | |||
| } | |||
|
|
|||
| private async getParentRetryableGas({ | |||
There was a problem hiding this comment.
Suggested change
| private async getParentRetryableGas({ | |
| private async getDepositRetryableFees({ |
brtkx
dismissed stale reviews from fionnachan and dewanshparashar
via
26d5d17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETH transfers to a custom destination address use retryables (https://github.com/OffchainLabs/arbitrum-sdk/blob/main/src/lib/assetBridger/ethBridger.ts#L339) so we need to also approve native currency gas in case for custom gas tokens.
To do that, we use
approvalAmountIncreaseoption in bridge-sdk. We bump it with the required gas.