Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report concept set presences that are 0 #11

Open
alondhe opened this issue May 13, 2024 · 3 comments
Open

Report concept set presences that are 0 #11

alondhe opened this issue May 13, 2024 · 3 comments
Assignees
Milestone

Comments

@alondhe
Copy link
Collaborator

alondhe commented May 13, 2024

When using addPresence, we currently lose line items for concept sets that have no presence during the time window.

For table reporting, it's useful to keep these in with N = 0 and Percent = 0.

@mdlavallee92 mdlavallee92 self-assigned this May 13, 2024
@mdlavallee92
Copy link
Collaborator

I will try to fix this but this maybe an artifact of summarizing in SQL. If there is no count for a concept set and I do a GROUP BY, it won't use an item that is not present.

Can add a post-processing step to add a placeholder for concept set with no presence or are below a minimum reportable value (say <5). Agree something should be done for sake of completeness

@alondhe
Copy link
Collaborator Author

alondhe commented May 13, 2024

Agreed, doesn't need to be during processing. But I think it'd be great if in the add(Domain)Presence functions, we keep a parameter like 'reportZero' and then in the finished categorical result, we get those items.

@mdlavallee92 mdlavallee92 added this to the v1.0.0 milestone Aug 9, 2024
@mdlavallee92
Copy link
Collaborator

adding to v1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants