Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyamlboot.tests: fix the eval #352825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Nov 1, 2024

Without the change the eval fails as:

$ nix build --no-link -f. pyamlboot.tests
error:
   … while evaluating the attribute 'version'
     at pkgs/by-name/py/pyamlboot/package.nix:29:3:
       28|
       29|   passthru.tests.version = testers.testVersion {
         |   ^
       30|     package = "pyamlboot";

   … while evaluating the 'name' attribute of a derivation

   … while evaluating a branch condition
     at lib/strings.nix:2627:3:
     2626|   # First detect the common case of already valid strings, to speed those up
     2627|   if stringLength string <= 207 && okRegex string != null
         |   ^
     2628|   then unsafeDiscardStringContext string

   (stack trace truncated; use '--show-trace' to show the full, detailed trace)

   error: expected a set but found a string: "pyamlboot"

After fixing the eval tests started failing as --version hardcodes 1.0.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix build --no-link -f. pyamlboot.tests
    error:
       … while evaluating the attribute 'version'
         at pkgs/by-name/py/pyamlboot/package.nix:29:3:
           28|
           29|   passthru.tests.version = testers.testVersion {
             |   ^
           30|     package = "pyamlboot";

       … while evaluating the 'name' attribute of a derivation

       … while evaluating a branch condition
         at lib/strings.nix:2627:3:
         2626|   # First detect the common case of already valid strings, to speed those up
         2627|   if stringLength string <= 207 && okRegex string != null
             |   ^
         2628|   then unsafeDiscardStringContext string

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: expected a set but found a string: "pyamlboot"

After fixing the eval tests started failing as `--version` hardcodes 1.0.
@trofi trofi mentioned this pull request Nov 1, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants