Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tesseract: ensure fixupPhase is run, e.g. ensuring library codesigning on darwin #352788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elohmeier
Copy link
Contributor

Since the tesseract wrapper replaces the phases in tesseractBase with it's buildCommand, this prevents running e.g. the fixupPhase which would codesign the modified library for darwin.
This change ensures the fixupPhase is executed, ensuring a valid code signature for libtesseract.5.dylib.

Before the change:

$ nix-build -A tesseract5.tesseractBase
/nix/store/5f9hf5d2lgdkb44x60khx5b2cm50xyv5-tesseract-5.3.4
$ codesign -vvv result/lib/libtesseract.5.dylib
result/lib/libtesseract.5.dylib: valid on disk
result/lib/libtesseract.5.dylib: satisfies its Designated Requirement

$ nix-build -A tesseract5
/nix/store/zxmnplp54g4iks4h9hrllfrd2rlbbj20-tesseract-5.3.4
$ codesign -vvv result/lib/libtesseract.5.dylib
result/lib/libtesseract.5.dylib: invalid signature (code or signature have been modified)
In architecture: arm64

After the change:

$ nix-build -A tesseract5.tesseractBase
/nix/store/5f9hf5d2lgdkb44x60khx5b2cm50xyv5-tesseract-5.3.4
$ codesign -vvv result/lib/libtesseract.5.dylib
result/lib/libtesseract.5.dylib: valid on disk
result/lib/libtesseract.5.dylib: satisfies its Designated Requirement

$ nix-build -A tesseract5
/nix/store/zxmnplp54g4iks4h9hrllfrd2rlbbj20-tesseract-5.3.4
$ codesign -vvv result/lib/libtesseract.5.dylib
result/lib/libtesseract.5.dylib: valid on disk
result/lib/libtesseract.5.dylib: satisfies its Designated Requirement

Fixes #350072.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: python312Packages.pymupdf @ 1.24.10 on Darwin
1 participant