Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added segment picking from faces #428

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

lej0hn
Copy link
Contributor

@lej0hn lej0hn commented Sep 13, 2024

  • Used FacePickingFilter to get face clicked

  • Get segment from face

  • Get info for segment

  • Is disabled for schematic viewing

@sanjayankur31 sanjayankur31 self-assigned this Sep 16, 2024
@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Sep 16, 2024
@sanjayankur31 sanjayankur31 marked this pull request as ready for review September 16, 2024 09:30
@sanjayankur31
Copy link
Member

Works very well @lej0hn 👍 . Could you link to the sources/docs you used to come up with this? I'll comment the code so that its easier to update/modify/maintain in the future for us.

I've got it merged in my local branch, but will push once I've commented the code etc.

@lej0hn
Copy link
Contributor Author

lej0hn commented Oct 3, 2024

Works very well @lej0hn 👍 . Could you link to the sources/docs you used to come up with this? I'll comment the code so that its easier to update/modify/maintain in the future for us.

I've got it merged in my local branch, but will push once I've commented the code etc.

Great, if you need anything regarding the docs please let me know!
The main resource is regarding the face_picking_filter that the implementation was based on which is in this link:
https://vispy.org/gallery/scene/face_picking.html#sphx-glr-gallery-scene-face-picking-py

@sanjayankur31
Copy link
Member

Cool---does the example change the color (or use some other method) to indicate what was clicked on perhaps? I'm trying to figure out how to pull this in in its current form. Perhaps a quick QT wrapper app that has an "info" pane to just print what we have so far would be a start. What do you think?

@sanjayankur31 sanjayankur31 merged commit 8751faf into NeuroML:development Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Type: enhancement
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants