-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization: handle referenced morphologies #415
Merged
sanjayankur31
merged 24 commits into
development
from
feat/handle-referenced-morphologies
Aug 23, 2024
Merged
Visualization: handle referenced morphologies #415
sanjayankur31
merged 24 commits into
development
from
feat/handle-referenced-morphologies
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are both cells and morphologies, we assume that the cells are referencing the morphologies, and then we do not also process the morphologies.
sanjayankur31
changed the title
3D Visualization: handle referenced morphologies
Visualization: handle referenced morphologies
Aug 12, 2024
Requires NeuralEnsemble/libNeuroML#197 |
[skip ci]
The top level function now allows users to pass color options to the underlying functions.
Looks nicer than a large flat cylinder in most cases.
This is necessary because the fix morphology etc. methods cannot find included file otherwise.
Color can also be a tuple (r, g, b), so we need to handle this case too.
Requires: NeuralEnsemble/libNeuroML#198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.