Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker support for Nemo/Nccl testing #18

Merged
merged 4 commits into from
May 18, 2024
Merged

Conversation

amaslenn
Copy link
Contributor

@amaslenn amaslenn commented May 17, 2024

Summary

  1. Update docker support for Nemo/Nccl testing
  2. This PR depends on Flat tests structure, fix warnings #17.

Test Plan

1. Test by @amaslenn
CI
2. Test by @TaekyungHeo
2.1 Slurm command generation for a given URL

  [cmd_args.docker_image_url]
  type = "str"
  default = [URL]
$ cloudaix --mode dry-run --system_config_path ... --test_scenario_path conf/v0.6/general/test_scenario/nemo_launcher.toml 
... container=**[installed_docker_image_path]**

2.1 Slurm command generation for a given path

  [cmd_args.docker_image_url]
  type = "str"
  default = [local_file_path]
$ cloudaix --mode dry-run --system_config_path ...--test_scenario_path conf/v0.6/general/test_scenario/nemo_launcher.toml 
... container=[local_file_path]

Additional Notes

@srinivas212 srinivas212 merged commit 6dc690e into main May 18, 2024
2 checks passed
@srinivas212 srinivas212 deleted the docker-path branch May 21, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants