Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pki-design-considerations.md #7936

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

florinbelea
Copy link
Contributor

updated KSP Key size and added references to CNG Key storage

updated KSP Key size and added references to CNG Key stoarage
Copy link
Contributor

@florinbelea : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 44e0b42:

⚠️ Validation status: warnings

File Status Preview URL Details
WindowsServerDocs/identity/ad-cs/pki-design-considerations.md ⚠️Warning Details

WindowsServerDocs/identity/ad-cs/pki-design-considerations.md

  • Line 142, Column 56: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/windows/win32/seccng/key-storage-and-retrieval' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 142, Column 56: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/windows/win32/seccng/key-storage-and-retrieval' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ShannonLeavitt
Copy link
Contributor

#assign: @robinharwood, @Xelu86

@robinharwood @Xelu86
Can you review the proposed changes?

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 3, 2024
removed hardcoded language for link
Copy link
Contributor

Learn Build status updates of commit 00a4b39:

💡 Validation status: suggestions

File Status Preview URL Details
WindowsServerDocs/identity/ad-cs/pki-design-considerations.md 💡Suggestion Details

WindowsServerDocs/identity/ad-cs/pki-design-considerations.md

  • Line 142, Column 56: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/windows/win32/seccng/key-storage-and-retrieval' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants