Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aks updated doc #60

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Aks updated doc #60

wants to merge 8 commits into from

Conversation

naman-msft
Copy link
Collaborator

@naman-msft naman-msft commented Apr 4, 2024

Updated it to resemble the current MS Learn reference AKS doc: https://learn.microsoft.com/en-us/azure/aks/learn/quick-kubernetes-deploy-cli

export SSL_EMAIL_ADDRESS="$(az account show --query user.name --output tsv)"
export MY_RESOURCE_GROUP_NAME="myAKSResourceGroup$RANDOM_ID"
export MY_RESOURCE_GROUP_NAME="myResourceGroup$RANDOM_ID"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this back to myAKSResourceGroup$RANDOM_ID? It can get confusing with many exec docs if they all have the same prefix name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ie.log Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this and the kubectl file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

```bash
echo "You can now visit your web server at https://$FQDN"
```

## Next Steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tell the user to visit the site at the end once it's ready. Like:
 

echo "You can now visit your web server at $IP_ADDRESS"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants