Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial-custom-images.md and change --managed-image to --virtual-machine parameter. #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dxaz
Copy link

@Dxaz Dxaz commented Sep 30, 2024

--managed-image need to get replaced with --virtual-machine as it takes a Virtual Machine ID given in the steps above while --managed-image requires a manged image resource ID.

Using managed-image parameter here will throw an error:
The gallery image version source id: '/subscriptions/0000-0000-0000-0000/resourceGroups/myGalleryRG/providers/Microsoft.Compute/virtualMachines/myVM' must be specified in 'galleryImageVersion.properties.storageProfile.source.virtualMachineId'.
Target: galleryImageVersion.properties.storageProfile.source

az sig image-version create states this in the documentation:
https://learn.microsoft.com/en-us/cli/azure/sig/image-version?view=azure-cli-latest#az-sig-image-version-create-optional-parameters

As well as the examples:

Add a new image version with encryption using a disk encryption set. Encryption is applied to each disk that is a part of the image version.

Azure CLI

Copy

Open Cloud Shell
az sig image-version create --resource-group MyResourceGroup
--gallery-name MyGallery --gallery-image-definition MyImage
--gallery-image-version 1.0.0
--virtual-machine /subscriptions/00000000-0000-0000-0000-00000000xxxx/resourceGroups/imageGroups/providers/Microsoft.Compute/virtualMachines/MyVM
--target-regions westus=2=standard eastus
--target-region-encryption WestUSDiskEncryptionSet1,0,WestUSDiskEncryptionSet2
EastUSDiskEncryptionSet1,0,EastUSDiskEncryptionSet2

--managed-image need to get replaced with --virtual-machine as it takes a Virtual Machine ID given in the steps above while --managed-image requires a manged image resource ID.

Using managed-image parameter here will throw an error:
 The gallery image version source id: '/subscriptions/0000-0000-0000-0000/resourceGroups/myGalleryRG/providers/Microsoft.Compute/virtualMachines/myVM' must be specified in 'galleryImageVersion.properties.storageProfile.source.virtualMachineId'.
Target: galleryImageVersion.properties.storageProfile.source
Copy link
Contributor

@Dxaz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link

Learn Build status updates of commit ffd73c8:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/linux/tutorial-custom-images.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Sep 30, 2024

@mattmcinnes
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 30, 2024
@Dxaz Dxaz changed the title Update tutorial-custom-images.md and change --managed-image to --virtual-machine parameter. Update tutorial-custom-images.md and change --managed-image to --virtual-machine parameter. Oct 1, 2024
cuteness03 pushed a commit to cuteness03/azure-compute-docs that referenced this pull request Oct 14, 2024
Updating steps for accessing live logs and customization log
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Oct 15, 2024
@Dxaz
Copy link
Author

Dxaz commented Oct 15, 2024

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @mattmcinnes

@Jak-MS
Copy link
Contributor

Jak-MS commented Oct 15, 2024

@mattmcinnes - nudge. this has been waiting a while... can you take a look ? thanks.

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Oct 16, 2024
@Dxaz
Copy link
Author

Dxaz commented Oct 29, 2024

Hey @mattmcinnes can I get you take a quick look, it'll take 10 minutes of time to look and test to verify the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants