Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scripts for Azure Image Builder #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BJD1997
Copy link

@BJD1997 BJD1997 commented Sep 5, 2024

Hi, I made some modifications to scripts and code blocks related to Azure Image builder role definitions.
Noticed the scripts were invalid when running and fixed them for myself and would like to share the working scripts with the rest of the world :)

Fixed the script to create the Image Builder Role Definition.
There were missing dollar signs for the variables and soms wrongly placed quotes.
Fixed the script to create the Image Builder Role Definition.
There were missing dollar signs for the variables and soms wrongly placed quotes.

Fixed multiple variables in other code snippets
Copy link
Contributor

@BJD1997 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Sep 5, 2024

@kof-f

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 5, 2024
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants