-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing resetState
methods to 4 assets-controllers
#4880
Merged
cryptodev-2s
merged 6 commits into
main
from
cryptodev2s/add-missing-reset-state-functions-assets-controllers
Oct 31, 2024
Merged
fix: add missing resetState
methods to 4 assets-controllers
#4880
cryptodev-2s
merged 6 commits into
main
from
cryptodev2s/add-missing-reset-state-functions-assets-controllers
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
changed the title
fix: add missing resetState methods
fix: add missingOct 31, 2024
resetState
methods to some assets-controllers
cryptodev-2s
changed the title
fix: add missing
fix: add missing Oct 31, 2024
resetState
methods to some assets-controllers
resetState
methods to some assets-controllers
cryptodev-2s
changed the title
fix: add missing
fix: add missing Oct 31, 2024
resetState
methods to some assets-controllers
resetState
methods to 4 assets-controllers
sahar-fehri
previously approved these changes
Oct 31, 2024
…s-assets-controllers
mcmire
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to reset the controller state to default state rather than initial state?
…s-assets-controllers
mcmire
reviewed
Oct 31, 2024
mcmire
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
cryptodev-2s
deleted the
cryptodev2s/add-missing-reset-state-functions-assets-controllers
branch
October 31, 2024 20:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add the missing
resetState
method toNftController
,TokensController
,TokenBalancesController
, andTokenRatesController
. These methods are needed on mobile and are currently patched here: MetaMask Mobile Patch.References
Changelog
@metamask/assets-controllers
resetState
method toNftController
,TokensController
,TokenBalancesController
andTokenRatesController
to reset the controller's state back to their initial stateChecklist