477 release gsdesign2 v113 #480
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdblischak
reviewed
Oct 28, 2024
NEWS.md
Outdated
| - Add robust check if `lower` is equivalent to `gs_b` (#413, thanks to @jdblischak ) | ||
| - The `summary()`, `as_gt()` `as_rtf()`, and `to_integer()` functions are refactored (#448, #449, #450, #465, #461, thanks to @yihui). | ||
| - Remove the `full_alpha` argument from `as_rtf.gs_design()` (#458, thanks to @yihui). | ||
| - Other coding practice improvement wroth mentioning (#409, #412, #429, #437, #440, #447, #453, #464, #467, $475, thanks to @yihui, @nanxstats, and @jdblischak). |
There was a problem hiding this comment.
Suggested change
| - Other coding practice improvement wroth mentioning (#409, #412, #429, #437, #440, #447, #453, #464, #467, $475, thanks to @yihui, @nanxstats, and @jdblischak). | |
| - Other coding practice improvement worth mentioning (#409, #412, #429, #437, #440, #447, #453, #464, #467, $475, thanks to @yihui, @nanxstats, and @jdblischak). |
|
With this many bug fixes, new features, and changes that are backward compatible, 1.2.0 might be more reasonable. |
jdblischak
approved these changes
Oct 29, 2024
|
Just remembered that we need to update |
Thanks for proposing the alternative. I will confirm with Keaven to check if he has any preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be merged after the PR #479 is merged.