Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix broken link in contributing.md #13658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AD7six
Copy link

@AD7six AD7six commented Sep 12, 2024

Summary

https://github.com/Kong/kong/blob/master/CHANGELOG/README.md does not exist.

Fix the url. Although, should that point at changelog-template.yaml instead?

I don't see anything in that readme directly relevant to contributors (who are not going to be generating a changelog themselves). Alternatively, as a new contributor, I'm not sure how to read these instructions and would be happy to update them :).

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Sep 12, 2024
Although, should that point at
https://github.com/Kong/kong/blob/master/changelog/changelog-template.yaml
? There does not appar to be anything in that readme for contributors to
read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) core/docs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants