-
Notifications
You must be signed in to change notification settings - Fork 745
Conversation
dc7f865
to
4f4e5f7
Compare
Travis is failing just because the footprint doesn't exist, which will be resolved by KiCad/kicad-footprints#2293 |
For FT5HN, could you stack the two GND pins? if you look at the existing oscillator symbols they seem to have a square or sine waveform drawn inside the symbol - consider that. mouser is probably not the original datasheet source? is there an alternative link from the manufacturer? |
That's a good idea. I'll make the changes but it will be a few days until
I'm at a computer.
…On Tue, May 26, 2020, 11:05 Anders Wallin ***@***.***> wrote:
For FT5HN, could you stack the two GND pins?
if you look at the existing oscillator symbols they seem to have a square
or sine waveform drawn inside the symbol - consider that.
mouser is probably not the original datasheet source? is there an
alternative link from the manufacturer?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2754 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJM4WHIXI77V74FZ57MO2TRTQAHFANCNFSM4NJTKETQ>
.
|
@aewallin thanks for the review, changes made:
|
@aewallin any more changes requested? |
Closing/opening to refresh the Travis test. |
Hello @bitglue and thanks @aewallin for the first steps of the review Complete review of the symbols: FT5HN
FT5HV
Else, just need to wait the footprint Joel |
@bitglue ping |
No news of the original author, indicate the PR is abandoned. |
@myfreescalewebpage rebump |
Thanks, just need to wait the footprint now. |
@myfreescalewebpage footprint has been merged. There are also 3D models, not sure who to ping on those since there haven't been any comments yet: KiCad/kicad-packages3D-source#282 Also I have some 3D models for a different component, if you could nudge them along I'd appreciate it: KiCad/kicad-packages3D-source#281 |
Thanks to ping me on this, no more comment and merging. For the packages 3D we are not a lot to be confortable with the review, this may take more time. |
Datasheet: https://www.mouser.com/datasheet/2/160/T5HN_T5HV-1662393.pdf
Footprint: KiCad/kicad-footprints#2293
3D model: KiCad/kicad-packages3D#699
3D model source: KiCad/kicad-packages3D-source#282
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.