-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe: MEOS #9453
base: master
Are you sure you want to change the base?
New recipe: MEOS #9453
Conversation
This fails on PROJ not being found, because: However, I'm not sure how/why the libgfortran(3) gets injected, and why PROJ_jll has no such mapping, whereas GEOS_jll with a similar mapping does. edit: @giordano Could you help me out here? I'm overlooking something, but can't pinpoint it. |
I'd suggest not doing that. The postfix is not really liked by the general registry, so while we use it for the individual builds here, it would be better to not rely on it for this. How soon will upstream release 1.2.0? |
Co-authored-by: Ian McInerney <[email protected]>
Fair enough, let's wait for the 1.2.0 release, but I'm not sure how soon that will be. For now, this is also still blocked on Windows ( |
We just produced the v1.2.0 release of MEOS. Feel free to let us know if you encounter any issues with it. |
|
||
# Collection of sources required to complete build | ||
sources = [ | ||
GitSource("https://github.com/MobilityDB/MobilityDB.git", "60048b5b4b7ce2f7560c024d1af024db73b3bd5b") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused: why is the recipe called MEOS build it builds a project called "MobilityDB". I just went to https://github.com/MobilityDB/MobilityDB and it doesn't mention "MEOS" in the README.md (though there is a subdirectory called meos
).
So is MEOS a subset of MobilityDB? But building MobilityDB for some reason... only builds and installs MEOS, not the whole thing?
Perhaps it would be good to add a few comments to explain the situation? Or rename this recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's explained in the PR description (and on the linked website). I will add a similar comment with the link to the source here.
Dependency(PackageSpec(name="GEOS_jll", uuid="d604d12d-fa86-5845-992e-78dc15976526")) | ||
Dependency(PackageSpec(name="JSON_C_jll", uuid="9cdfc4e7-e793-5089-b6f7-569a57a60f0a")) | ||
Dependency(PackageSpec(name="PROJ_jll", uuid="58948b4f-47e0-5654-a9ad-f609743f8632")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need compat bounds for geos (#3844) and proj (I guess there's a reason if there's a non-zero major offset at
Yggdrasil/P/PROJ/build_tarballs.jl
Line 7 in 6bd4ab3
version_offset = v"2.0.0" |
See https://libmeos.org/
edit: This release now points to the release candidate 1 release (as it requires no patches) to build. Is it ok to set the version number to v1.2.0 already and later at the actual release just rerunning it with the new commits (producing a jll with the +1 postfix)?