Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MONA v1.4.18 #9440

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

JeffersonYeh
Copy link

No description provided.

@JeffersonYeh
Copy link
Author

Hi, I'm trying to build this with the wizard. It builds successfully for linux distributions however fails for Windows i686, Windows x86_64 and macOS aarch64.

I think that the issues are caused by: the windows build requires cygwin and the mac build requires a newer version of ld64.lld. I'm a little confused regarding how I should include / update these. Should I include them in the (binary) dependencies step?

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the code, but based on the error message

[12:29:10] mona.cpp:31:26: fatal error: sys/resource.h: No such file or directory
[12:29:10]  #include <sys/resource.h>

I take they just don't support Windows, and I guess you'll have to remove that platform

M/MONA/build_tarballs.jl Outdated Show resolved Hide resolved
M/MONA/build_tarballs.jl Outdated Show resolved Hide resolved
@giordano
Copy link
Member

https://buildkite.com/julialang/yggdrasil/builds/13290#0191facc-9d57-47cc-8cc9-fab915281976/676-1631

ERROR: could not load library "/cache/build/yggy-amdci7-4/julialang/yggdrasil/M/MONA/build/x86_64-linux-gnu/hVJMUnDy/x86_64-linux-gnu-libgfortran3-cxx03/destdir/lib/libmonagta.so.1.0.4"
/cache/build/yggy-amdci7-4/julialang/yggdrasil/M/MONA/build/x86_64-linux-gnu/hVJMUnDy/x86_64-linux-gnu-libgfortran3-cxx03/destdir/lib/libmonagta.so.1.0.4: undefined symbol: guide
┌ Warning: lib/libmonagta.so.1.0.4 cannot be dlopen()'ed
└ @ BinaryBuilder.Auditor /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilder/HTdhp/src/Auditor.jl:173

that looks like a potential problem

@JeffersonYeh
Copy link
Author

JeffersonYeh commented Sep 16, 2024

I haven't looked at the code, but based on the error message

[12:29:10] mona.cpp:31:26: fatal error: sys/resource.h: No such file or directory
[12:29:10]  #include <sys/resource.h>

I take they just don't support Windows, and I guess you'll have to remove that platform

On their website, windows is supposed to be suggested. Stackoverflow suggests that its because windows is missing Cygwin for the POSIX header (https://stackoverflow.com/questions/64710582/error-using-include-sys-resource-h-with-windows-10-c).

How should I include Cygwin into the build environment? Perhaps through dependencies or installation in the script?

Thanks!

@giordano
Copy link
Member

We don't support cygwin, we only support real Windows targets with mingw.

@JeffersonYeh JeffersonYeh marked this pull request as ready for review September 17, 2024 22:03
@JeffersonYeh
Copy link
Author

I removed the windows and mac platforms for now.

M/MONA/build_tarballs.jl Outdated Show resolved Hide resolved
M/MONA/build_tarballs.jl Outdated Show resolved Hide resolved
@eschnett
Copy link
Contributor

eschnett commented Oct 1, 2024

You can try one or both of the options -Wl,-undefined and -Wl,dynamic_lookup on Apple platforms. See e.g.

if [[ "${target}" == *-apple-* ]]; then
. This may or may not be the right approach; it might also be an error in the makefile in the GTA directory.

./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target}
extra=""
if [[ "${target}" == *-apple-* ]]; then
extra="LDFLAGS=\"-Wl,-undefined dynamic_lookup\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is incorrect. I don't know exactly what flag you want to pass to the linker (and the syntax for that is also wrong), but in the first instance you need to remove all the \".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants