[aws_checksums] Update to version 0.1.19

[quinnj2]

This PR updates aws_checksums to version 0.1.19. cc: @quinnj @Octogonapus

[giordano]

@quinnj this is failing.

[giordano]

Ok, now error on aarch64-linux is

[15:46:03] /opt/bin/aarch64-linux-gnu-libgfortran3-cxx11/aarch64-linux-gnu-gcc --sysroot=/opt/aarch64-linux-gnu/aarch64-linux-gnu/sys-root/ -DAWS_CHECKSUMS_EXPORTS -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DHAVE_SYSCONF -DINTEL_NO_ITTNOTIFY_API -Daws_checksums_EXPORTS -I/workspace/srcdir/aws-checksums/include -O3 -DNDEBUG -fPIC -Wall -Wstrict-prototypes -Wextra -pedantic -Wno-long-long -fPIC -fvisibility=hidden -pthread -std=gnu99 -MD -MT CMakeFiles/aws-checksums.dir/source/crc_sw.c.o -MF CMakeFiles/aws-checksums.dir/source/crc_sw.c.o.d -o CMakeFiles/aws-checksums.dir/source/crc_sw.c.o -c /workspace/srcdir/aws-checksums/source/crc_sw.c
[15:46:03] /opt/bin/aarch64-linux-gnu-libgfortran3-cxx11/aarch64-linux-gnu-gcc --sysroot=/opt/aarch64-linux-gnu/aarch64-linux-gnu/sys-root/ -DAWS_CHECKSUMS_EXPORTS -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DHAVE_SYSCONF -DINTEL_NO_ITTNOTIFY_API -Daws_checksums_EXPORTS -I/workspace/srcdir/aws-checksums/include -O3 -DNDEBUG -fPIC -Wall -Wstrict-prototypes -Wextra -pedantic -Wno-long-long -fPIC -fvisibility=hidden -pthread -std=gnu99   -march=armv8-a+crc+crypto -mtune=neoverse-v1 -MD -MT CMakeFiles/aws-checksums.dir/source/arm/crc32c_arm.c.o -MF CMakeFiles/aws-checksums.dir/source/arm/crc32c_arm.c.o.d -o CMakeFiles/aws-checksums.dir/source/arm/crc32c_arm.c.o -c /workspace/srcdir/aws-checksums/source/arm/crc32c_arm.c
[15:46:03] /opt/bin/aarch64-linux-gnu-libgfortran3-cxx11/aarch64-linux-gnu-gcc --sysroot=/opt/aarch64-linux-gnu/aarch64-linux-gnu/sys-root/ -DAWS_CHECKSUMS_EXPORTS -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DHAVE_SYSCONF -DINTEL_NO_ITTNOTIFY_API -Daws_checksums_EXPORTS -I/workspace/srcdir/aws-checksums/include -O3 -DNDEBUG -fPIC -Wall -Wstrict-prototypes -Wextra -pedantic -Wno-long-long -fPIC -fvisibility=hidden -pthread -std=gnu99   -march=armv8-a+crc+crypto -mtune=neoverse-v1 -MD -MT CMakeFiles/aws-checksums.dir/source/arm/crc64_arm.c.o -MF CMakeFiles/aws-checksums.dir/source/arm/crc64_arm.c.o.d -o CMakeFiles/aws-checksums.dir/source/arm/crc64_arm.c.o -c /workspace/srcdir/aws-checksums/source/arm/crc64_arm.c
[15:46:03] /workspace/srcdir/aws-checksums/source/arm/crc32c_arm.c:1:0: error: unknown value ‘neoverse-v1’ for -mtune
[15:46:03]  /**
[15:46:03]  ^
[15:46:03] make[2]: *** [CMakeFiles/aws-checksums.dir/build.make:132: CMakeFiles/aws-checksums.dir/source/arm/crc32c_arm.c.o] Error 1
[15:46:03] make[2]: *** Waiting for unfinished jobs....
[15:46:03] /workspace/srcdir/aws-checksums/source/arm/crc64_arm.c:1:0: error: unknown value ‘neoverse-v1’ for -mtune
[15:46:03]  /**

GCC 11 is required to target neoverse-v1: https://gcc.gnu.org/gcc-11/changes.html. But I'm a bit concerned by them requiring tuning for such a relatively recent CPU.

[quinnj]

Hmmmm, that sounds above my skillset for dealing with 😅

[giordano]

My first suggestion would be to patch the build system to remove the tuning option, but I'd really like to understand why they're doing that in the first place. Do they really require Neoverse-v1? That sounds a bit excessive, not even apple silicon would match that.