Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alsa] Bump to v1.2.11 #8485

Closed
wants to merge 5 commits into from
Closed

[alsa] Bump to v1.2.11 #8485

wants to merge 5 commits into from

Conversation

gnadt
Copy link

@gnadt gnadt commented Apr 16, 2024

Now just bumping alsa

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Shoot I also just bumped [alsa_plugins] to v1.2.7, forgetting that would get added in here

]

# Bash recipe for building across all platforms
script = raw"""
cd $WORKSPACE/srcdir/alsa-lib*/
./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target}
./configure --prefix=${prefix} --with-configdir=/usr/share/alsa --with-plugindir=/usr/lib/alsa-lib --build=${MACHTYPE} --host=${target}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's slightly awkward to hardcode them like this, but I guess there isn't really a good way around that. Have you tested this locally to make sure the paths all work out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that work on nix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not on nix, and this will also reference the user's existing Alsa stuff, not anything we provide in the JLL. There are apparently environment variables that could be used to work around this at runtime (they basically override this setting apparently).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was moderately sure we were doing this already

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to having an init block like (it's a sketch, totally untested):

get!(ENV, "ALSA_PLUGIN_DIR", joinpath(artifact_dir, "lib", "alsa-lib"))

rather than hardcoding absolute paths that we can't know whether will exist. Other projects seem to be doing this already, e.g. JuliaMultimedia/SimpleDirectMediaLayer.jl#65

@gnadt gnadt changed the title [alsa] Bump to v1.2.11, specify config and plugin directories [alsa] Bump to v1.2.11 Apr 16, 2024
@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Thanks for the discussion & link!

@giordano
Copy link
Member

I think you still want to add the init block? After testing it of course 🙂 I have no idea of what to test

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

Oh sorry I got confused, I thought the move was just to add it^ to any downstream packages using alsa_jll. I can build locally (though that's the same as the checks here), but I don't have a linux system to test locally

@giordano
Copy link
Member

No, I was suggesting setting the keyword argument init_block to build_tarballs in this package (but pointing only to files within the tarball), so that all downstream packages automatically get the fix.

@gnadt
Copy link
Author

gnadt commented Apr 16, 2024

I don't think I have the expertise to do that, and that's just an experimental argument, right? I'm clueless how artifact_dir would be determined during the build, since isn't that what's being built? I'm probably missing some fundamental understanding here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants