Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiskArrays dependency to 0.4 #140

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Update DiskArrays dependency to 0.4 #140

merged 3 commits into from
Apr 22, 2024

Conversation

meggart
Copy link
Collaborator

@meggart meggart commented Apr 2, 2024

The whole indexing pipeline was reformulated in DiskArrays 0.4 fixing many bugs for strange vector indexing patterns. In addition this will finally make all types of getindex calls type stable.

This is not ready to merge yet since Zarr tests revealed one upstream bug.

@felixcremer
Copy link
Contributor

Could this be merged now that the upstream bug is fixed and released in DiskArrays 0.4.2?
I tested locally with DiskArrays 0.4.2 and didn't see the error anymore but have reported #144 but this also happens with DiskArrays 0.3 and seems to be independent.

Copy link
Contributor

Pull Request Test Coverage Report for Build 8783611095

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 85.946%

Totals Coverage Status
Change from base Build 8519573721: -2.5%
Covered Lines: 795
Relevant Lines: 925

💛 - Coveralls

@meggart meggart merged commit 9ac31cb into master Apr 22, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants