Run full GC when under very high memory pressure. #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 157 157
Lines 15197 15197
=======================================
Hits 11135 11135
Misses 4062 4062 ☔ View full report in Codecov by Sentry. |
|
@pxl-th I take it you've verified that this doesn't regress things and is good to have? |
|
Yes, it helps. Although for some really intense workloads it is still not enough (observed with AMDGPU). Probably needs further finetuning |
|
Great, thanks, then we can start with this already. |
maleadt
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref JuliaGPU/AMDGPU.jl#645