Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FFT execution on separate Julia task #689

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix FFT execution on separate Julia task #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68432d6
Fix FFT execution on separate stream
jipolanco Oct 11, 2024
9e7d96a
Add test
jipolanco Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/fft/fft.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ function update_stream!(plan::ROCFFTPlan)
new_stream = AMDGPU.stream()
if plan.stream != new_stream
plan.stream = new_stream
info = plan.execution_info
rocfft_execution_info_set_stream(info, new_stream)
end
return
Expand Down
15 changes: 15 additions & 0 deletions test/rocarray/fft.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,4 +334,19 @@ end
end
end

@testset "Asynchronous" begin
X = rand(Float32, 10, 10)
d_X = ROCArray(X)

p = plan_rfft(X)
d_p = plan_rfft(d_X)

Y = p * X

task = Threads.@spawn d_p * d_X # executes FFT on separate AMDGPU stream
d_Y = fetch(task)

@test isapprox(collect(d_Y), Y; rtol=MYRTOL, atol=MYATOL)
end

end # testset FFT