Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFT execution on separate Julia task #689

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jipolanco
Copy link
Contributor

This PR fixes the execution of an FFT plan on a different AMDGPU stream (or Julia task) from the one used to create the plan.

Example:

using AMDGPU
using AbstractFFTs

x = ROCArray(rand(Float32, 100, 200))

p = plan_rfft(x)
y = p * x

task = Threads.@spawn p * x   # this currently fails! (switches to a different stream)
z = fetch(task)

Array(z) == Array(y)  # should be true

This currently fails simply because the info variable is not defined in update_stream!.

@pxl-th
Copy link
Collaborator

pxl-th commented Oct 11, 2024

Thanks!

@pxl-th pxl-th merged commit 09d9fda into JuliaGPU:master Oct 11, 2024
1 check passed
@jipolanco jipolanco deleted the jip/fft-stream branch October 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants