Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Object.assign transform #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ianwith
Copy link

@ianwith ianwith commented Apr 23, 2018

Problem

Object.assign breaks on iOS versions < 9

Solution

  1. add babel-plugin-transform-object-assign
  2. npm run build

@dcousens
Copy link
Collaborator

@ianwith can't you do this yourself for your own project? :/

@ianwith
Copy link
Author

ianwith commented Apr 24, 2018

I'm using babel-runtime in my project. Am I supposed to change configuration like this?

Before

{
  test: /\.(js|jsx)$/,
  exclude: /node_modules/,
  use: 'babel-loader'
},

After

{
  test: /\.(js|jsx)$/,
  include: [
    path.resolve(__dirname, 'src'),
    path.resolve(__dirname, 'node_modules/react-tappable')
  ],
  use: 'babel-loader'
},

@dcousens
Copy link
Collaborator

@ianwith depends on how you are compiling. Did the above succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants