Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to introduce friction when using the delete key #5669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

murphpdx
Copy link

@murphpdx murphpdx commented Jun 12, 2023

This feature requires that users hit the backspace key twice when deleting a value, unless the value is already selected.

I created a feature request here: #5670

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

⚠️ No Changeset found

Latest commit: fd8530f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd8530f:

Sandbox Source
react-codesandboxer-example Configuration

Comment on lines +1501 to +1509
if (backspaceFriction) {
if (focusedValue) {
this.removeValue(focusedValue);
return;
} else {
this.focusValue('previous');
return;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (backspaceFriction) {
if (focusedValue) {
this.removeValue(focusedValue);
return;
} else {
this.focusValue('previous');
return;
}
}
if (backspaceFriction && !focusedValue) {
this.focusValue('previous');
return;
}

@websiddu
Copy link

Looking forward for this to getting merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants