Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support aria-placeholder #5657

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seanlaff
Copy link

@seanlaff seanlaff commented Jun 5, 2023

The docs (https://react-select.com/props) define aria-placeholder as a supported prop, but as far as I could tell it wasn't actually supported. This changeset adds it.

Use case: I want to use page.getPlaceholder("Select foobar...") in playwright tests.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

🦋 Changeset detected

Latest commit: decabeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit decabeb:

Sandbox Source
react-codesandboxer-example Configuration

@seanlaff seanlaff changed the title support aria-placeholder fix: support aria-placeholder Jun 5, 2023
@seanlaff
Copy link
Author

seanlaff commented Jun 5, 2023

Not sure why the e2e tests timed out- I was going to retry the pipeline but I don't have permission

@seanlaff
Copy link
Author

@Methuselah96 Would you be able to re-run this pipeline for me to see if the e2e timeout resolves itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant