Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated lifecycle methods anymore #144

Closed
wants to merge 1 commit into from

Conversation

flash1293
Copy link

This change removes the usage of all lifecycle methods which are deprecated in the latest react version

@ivansky
Copy link

ivansky commented Jul 8, 2019

Actually componentDidUpdate is a bit different from componentWillReceiveProps.
Would be better to use new React API based on React version, e.g. getDerivedStateFromState.

@JedWatson
Copy link
Owner

Thanks for this @flash1293 and sorry it never got merged.

Fixed by #177

@JedWatson JedWatson closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants